Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce model-loop: minimize LMER/MERF dependencies in cross_validate #13

Closed
radlfabs opened this issue Nov 10, 2023 · 0 comments · Fixed by #17
Closed

Reduce model-loop: minimize LMER/MERF dependencies in cross_validate #13

radlfabs opened this issue Nov 10, 2023 · 0 comments · Fixed by #17
Assignees
Labels
enhancement New feature or request

Comments

@radlfabs
Copy link
Owner

Currently the cross validation loop iterates over base estimators..
With a flag we enter a second code block inside the loop where the mixed effects modeling takes place.
Therefore, LMER and MERF need to be treated differently as another model type as any other base estimator.
This is also due to the differences in API.
It would be benefitial to reduce this second part of the loop. MERF will always be in a different hierarchy because it is optimizing on top of base estimators. Unfortunately also LMER can not be base model inside MERF because MERF only supports fixed effects fitting internally for the base model.
A possible solution would be, to add a flag "fit_merf" to the ModelConfigDict, which triggers the part of the loop after fitting the base estimator to also enter into MERF fitting and evaluation.

@radlfabs radlfabs added the enhancement New feature or request label Nov 10, 2023
@radlfabs radlfabs added this to the Release 0.1.0 milestone Nov 10, 2023
@radlfabs radlfabs self-assigned this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant