Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knob stops responding when value is greater than defined maximum #37

Open
jakubhlavaty opened this issue Nov 7, 2016 · 1 comment
Open

Comments

@jakubhlavaty
Copy link

jakubhlavaty commented Nov 7, 2016

  1. let's have a knob with a defined maximum value (options.max)
  2. pass a value that's less or equal to the maximum value
  3. knob updates
  4. pass a value that's greater than the defined maximum
  5. knob updates to this value, but successive updates don't do anything (knob is frozen - doesn't react to changes to the value)

I would expect, that the value is either

  • displayed regardless of the maximum value
  • OR truncated to the maximum value
    and the arc shouldn't grow beyond the defined angles.

Here's a simple project that demonstrates this (it updates with a timer so just wait for it to freeze):
https://github.com/jakubhlavaty/ng-knob-bug

  • run sample with npm (see readme)
  • dependencies managed with bower (using ng-knob 0.1.3)
@jakubhlavaty jakubhlavaty changed the title Knob stop responding when value is greater than defined maximum Knob stops responding when value is greater than defined maximum Nov 7, 2016
jakubhlavaty pushed a commit to jakubhlavaty/ng-knob that referenced this issue Nov 7, 2016
@jakubhlavaty
Copy link
Author

Created a pull request. Please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant