Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set up jest for testing and istanbul for coverage check #19

Open
6 tasks
rae-ralston opened this issue Feb 2, 2018 · 4 comments · May be fixed by #25
Open
6 tasks

set up jest for testing and istanbul for coverage check #19

rae-ralston opened this issue Feb 2, 2018 · 4 comments · May be fixed by #25
Labels
good first issue Good for newcomers
Milestone

Comments

@rae-ralston
Copy link
Owner

rae-ralston commented Feb 2, 2018

  • Install and set up jest
  • write a single test that passes
  • install and set up istanbul
  • get a code coverage report
  • update the package.json with appropriate scripts
  • update the readme with instructions for future contributors on how to run the tests.
@rae-ralston rae-ralston added the good first issue Good for newcomers label Feb 2, 2018
@Atul9 Atul9 linked a pull request Feb 2, 2018 that will close this issue
@Atul9
Copy link

Atul9 commented Feb 2, 2018

Hi @rachel-ftw, I would like to contribute to this project. I tried to set it up. I provided my number for lyft credentials but I didn't get any message from them. I think they send messages only to US mobile numbers.

@rae-ralston
Copy link
Owner Author

Thanks for jumping on the project! 😍

As it stands, the Lyft API portion of the application is still under development, so you should still be able to contribute without it. Did you get the google geocoding & NPS API keys without trouble? They're the important ones for now.

To complete this issue I'd install and set up jest & istanbul and submit an PR with a single test passing & a test coverage report. issues #21 & #20 cover getting into test writing more. I just filled out this issue with more detail (see above).

To continue to contribute once the lyft portion is incremented you could get a VOIP US number to confirm with that. You could probably get something like https://voice.google.com/
Let me know if I can help you with that!

Thanks!

@rae-ralston rae-ralston modified the milestone: MVP Feb 2, 2018
@Atul9
Copy link

Atul9 commented Feb 2, 2018

Yes, I got google geocoding & NPS API keys. I have opened up a PR #25
To setup jest in continuous integration(CI) we need to set up this project in Travis or some other CI website. Can you set up this project in a CI/CD(continuous delivery) service?

@rae-ralston
Copy link
Owner Author

Thanks for logging the issue.
Yep. I'll be away from a computer for the next 24-ish hours, but I'll set it up on Sunday.
Thanks @Atul9! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants