-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
detect if dcrcli.conf is not configured #50
Comments
The above should also take care of the failures that show unfriendly errors such as $ ./dcrcli balance |
I've had that error even with dcrcli properly configured but without dcrwallet actually running... There might be another way to prevent that error. Will look into that |
I want to create a separate issue for this as it does not relate to the absence or presence of dcrcli configuration. The error is due to invalid rpc configuration values. Want to keep this issue and the associated PR #64 focused on just taking care of scenarios where dcrcli is not configured. EDIT: The error A similar error occurs when the dcrwallet rpc server address is set but dcrcli cannot connect to that address either because it is completely incorrect/invalid or because dcrwallet was not running at the time the connection attempt was made. For simplicity and focus, this issue and the associating PR should focus on detecting the absence of If a user manually creates a config file, a value for dcrwallet rpc server address may not be set in the config file and may not be passed in command-line options. |
This planetdecred/godcr#64 (comment) explains why this issue isn't actually an issue - or shouldn't have been an issue. In summary,
True
Not really. The rpc connection information we need are
This however is something that we could and prolly should do. Will make this into a separate low-priority issue. |
When running ./dcrcli with no commands, currently the simple dcrcli usage cmds are shown. But these commands are not yet available if the user does not have dcrcli.conf set with the correct rpc login information. So this should be detected, and a msg displayed to let the user know that they need to specify this information. The simple usage commands would not be displayed, and instead instructions would be displayed to set edit the config file or to specify the appropriate rpc command line options (-h).
Additionally, we could autoconfigure by looking for the default dcrwallet config and auto parsing the needed settings, asking the user if they would like to use these values.
The text was updated successfully, but these errors were encountered: