Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary overview - crit comparison is wrong #26

Closed
Neran28 opened this issue Jun 7, 2021 · 1 comment
Closed

Summary overview - crit comparison is wrong #26

Neran28 opened this issue Jun 7, 2021 · 1 comment

Comments

@Neran28
Copy link

Neran28 commented Jun 7, 2021

In the sum overview the comparison of crit% is wrong (german client).
At least thats the case in the example of having two items of which the one item has crit% from an agility source and the other item has crit from crit rating source.
In this example the equipped item has 1.01% crit from crit rating while the item in the inventory does have 1.27% crit from agility.
The comparison states that the item in the inventory results in a gain of 1.27% of crit% which means that the equipped item with the crit rating source is not taken into account.

This bug is probably related to another bug that causes crit rating not being displayed or recognized at all in the summary, also when turned on in the settings.

@Neran28 Neran28 changed the title Sum panel - crit comparison is wrong Summary overview - crit comparison is wrong Jun 7, 2021
raethkcj added a commit that referenced this issue Jun 7, 2021
@raethkcj
Copy link
Owner

raethkcj commented Jun 7, 2021

It was likely a missing German translation, should be fixed.

@raethkcj raethkcj closed this as completed Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants