Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes Ranged AP don't get calculated in summary #32

Closed
Citano opened this issue Jun 16, 2021 · 6 comments
Closed

Sometimes Ranged AP don't get calculated in summary #32

Citano opened this issue Jun 16, 2021 · 6 comments
Labels
bug Something isn't working

Comments

@Citano
Copy link

Citano commented Jun 16, 2021

For some reason, Ranged AP does not always get calculated as shown in the example here.
Not sure what triggers it nor how to reproduce.
image

@krydd
Copy link

krydd commented Jun 17, 2021

I have seen the same problem for some items as well:
rap_missing

@aeadio
Copy link
Contributor

aeadio commented Jun 19, 2021

Doesn't just happen for RAP. Happens for multiple stats, including melee AP. There seems to either be a delay in tooltip scanning logic, or it doesn't trigger sometimes. The actual calculation logic doesn't seem to be off, since it will eventually populate the values correctly if you keep trying, and/or reloading.

@raethkcj
Copy link
Owner

Item data aren't guaranteed to exist when you first set a tooltip to an item. RatingBuster caches the first result for performance whether it got any real data or not, so when the data comes in later, RatingBuster is stuck using its old empty cache version. For most of WoW there haven't been clean ways around this, but there are some new ItemMixin APIs since BFA that may help:

https://wowpedia.fandom.com/wiki/ItemMixin

It is odd that it's getting partial stats though, so it's possible there's actually just an issue with one or more of the StatLogic scanners.

@raethkcj raethkcj added the bug Something isn't working label Jul 6, 2021
@chefBrian
Copy link

Yeah this is also happening for mele ap. Agility isn't considered at all. Also cannot trigger AP conversion for AGI to be displayed either.

@raethkcj
Copy link
Owner

@chefBrian agi seems like a separate issue, what class and locale?

@chefBrian
Copy link

@raethkcj my fault - I will create a separate issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants