Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes: fix visual bug with dark themes in the settings menu #1355

Closed
Tristar7 opened this issue May 18, 2019 · 2 comments
Closed

Themes: fix visual bug with dark themes in the settings menu #1355

Tristar7 opened this issue May 18, 2019 · 2 comments
Milestone

Comments

@Tristar7
Copy link

Attached a picture for a quick explanation

https://i.imgur.com/V7mQwXP.png

I know this is a rather on the theme side to fix but it worked properly up until recently.
The columns were halved correctly, now it seems like something there changed that made it incompatible with the dark theme.

@SquishedPotatoe
Copy link

The permissions table re-uses the class from the user giveaway data table, my styles had a min-width set on that. If gsrafael01 intends to keep it that way you can add this to correct.

#esgst_permissions .esgst-ugd-table { min-width: unset; }

@rafaelgomesxyz rafaelgomesxyz changed the title Recent version has created an issue in the settings page with the dark theme with smaller window widths Themes: fix style issue with dark themes in the settings menu May 18, 2019
@rafaelgomesxyz rafaelgomesxyz added this to the 8.3.13 milestone May 18, 2019
@rafaelgomesxyz
Copy link
Owner

@SquishedPotatoe Thanks for the fix.

@rafaelgomesxyz rafaelgomesxyz changed the title Themes: fix style issue with dark themes in the settings menu Themes: fix visual bug with dark themes in the settings menu May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants