Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown error causes extension to stop working #1366

Closed
Eiion opened this issue May 20, 2019 · 8 comments
Closed

Unknown error causes extension to stop working #1366

Eiion opened this issue May 20, 2019 · 8 comments

Comments

@Eiion
Copy link

Eiion commented May 20, 2019

Description
Since this happened again, I decided it deserves it's own report:
Once again ESGST stopped working (no buttons/menus of ESGST get displayed on steamgifts), while still being displayed as running on Chrome.

Console Errors
One that's somewhat related on console:
cdn.steamgifts.com/js/prebid_v8.js:1 Failed to load resource: net::ERR_BLOCKED_BY_CLIENT

Several more on the extension's background page:

_generated_background_page.html:1 Uncaught (in promise) Object
_generated_background_page.html:1 Uncaught (in promise) Object
_generated_background_page.html:1 Uncaught (in promise) Object
browser-polyfill.js:1 Failed to send onMessage rejected reply TypeError: Message length exceeded maximum allowed length.
    at F.G.then.I (browser-polyfill.js:1)
(anonymous) @ browser-polyfill.js:1
2x browser-polyfill.js:1 Uncaught (in promise) Error: Cannot set property 'entries' of undefined
    at r (browser-polyfill.js:1)
2x browser-polyfill.js:1 Failed to send onMessage rejected reply TypeError: Message length exceeded maximum allowed length.
    at F.G.then.I (browser-polyfill.js:1)
(anonymous) @ browser-polyfill.js:1
7x browser-polyfill.js:1 Uncaught (in promise) Error: Cannot set property 'entries' of undefined
    at r (browser-polyfill.js:1)
2x browser-polyfill.js:1 Failed to send onMessage rejected reply TypeError: Message length exceeded maximum allowed length.
    at F.G.then.I (browser-polyfill.js:1)
(anonymous) @ browser-polyfill.js:1
2x browser-polyfill.js:1 Failed to send onMessage rejected reply TypeError: Message length exceeded maximum allowed length.
    at F.G.then.I (browser-polyfill.js:1)

System (please complete the following information):

  • ESGST Version: 8.3.13
  • Chrome Version 74.0.3729.157 (Official Build) (64-Bit)

Additional Context/Screenshot
File sizes have changed again:
Screenshot
Checking 003048.ldb I couldn't find any duplicate lines.

EDIT:
Closing/re-opening the browser once again doesn't fix it. This is the error on the background page:

3x browser-polyfill.js:1 Failed to send onMessage rejected reply TypeError: Message length exceeded maximum allowed length.
    at F.G.then.I (browser-polyfill.js:1)

And again the same error in console:
cdn.steamgifts.com/js/prebid_v8.js:1 Failed to load resource: net::ERR_BLOCKED_BY_CLIENT

@Eiion Eiion changed the title The extension stopped working Unknown error causes extension to stop working May 20, 2019
@rafaelgomesxyz
Copy link
Owner

cdn.steamgifts.com/js/prebid_v8.js:1 Failed to load resource: net::ERR_BLOCKED_BY_CLIENT

This error is irrelevant, it's not from ESGST.

It would be nice if you could detect the exact steps that would make this issue reproduceable, but I have a feeling this issue is random and depends on the storage, which will make it much harder to fix.

Did this start happening with a specific version?

@Eiion
Copy link
Author

Eiion commented May 20, 2019

It started with version 8.3.4.
(maybe this more general issue could be merged with too specific issue #1304).

What I did today was loading in all the giveaways from community train 4 and filter them. After joining a few I opened up a user profile in a new tab - where ESGST already didn't show up anymore.

First time it happened was after changing settings (see mentioned issue).

I could try reproducing the issue but time is an issue right now.

What I did try though was deleting (i.e. renaming) file 003048.ldb after switching of the extension in the extension manager.
I then restarted the browser and the extension, reloaded steamgifts and ESGST was running again.

The only thing missing that I immediately found was that individual hidden giveaways were displayed again.
I didn't have time to look further into it to see if other things are missing as well but I'm assuming that this file is the cash - or at least part of it.

Maby ESGST has trouble handling cash files that big (since there's no duplicate data inside the file) or there's an issue with addressing a large amount of data.

@rafaelgomesxyz
Copy link
Owner

I think the issue is more than that, because it doesn't make sense to go from ~2 MB to ~8 MB. My guess is that maybe something is happening when saving the storage that is corrupting it.

@Eiion
Copy link
Author

Eiion commented May 21, 2019

It maybe makes sense considering the train is over 1200 GAs long, resulting in data of 1200 giveaways to be stored? I don't know.
Either way, before 8.3.4 this wasn't an issue although loading in just as many GAs as well.

From here on I don't know what else to do. I loaded in the last backup and everything seems to be working as before.
(Maybe an automated backup would be nice, where the user can set the interval.)

@rafaelgomesxyz
Copy link
Owner

Automated backup is already an option.

@rafaelgomesxyz
Copy link
Owner

v8.3.14 should allow storing large files.

@rafaelgomesxyz
Copy link
Owner

If this hasn't happened since v8.3.14, I'm going to close this issue and consider it as solved, because I think it was just the extension not being able to handle large files and therefore corrupting the storage, so please let me know.

@Eiion
Copy link
Author

Eiion commented Jun 26, 2019

It hasn't happened since.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants