Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giveaway Extractor: fix bug that does not display cache for trains with less than 50 giveaways #1397

Closed
at46 opened this issue Jun 8, 2019 · 4 comments
Labels
Milestone

Comments

@at46
Copy link

at46 commented Jun 8, 2019

Description
When I open the giveaway extractor cache there are no giveaways even without filters.

Steps to Reproduce

  1. extract all giveaways
  2. open the cache

Expected Behavior
See the cached giveaways

Console Errors
nothing

Screenshots
ge_cache

System (please complete the following information):

  • ESGST Version: Extension v8.3.15
  • Browser + Version: Firefox v67.0.1

Additional Context
I've set the giveaway extractor to use a new tab instead of a popup

@rafaelgomesxyz rafaelgomesxyz added this to the 8.3.16 milestone Jun 20, 2019
@rafaelgomesxyz
Copy link
Owner

Only for trains less than 50 giveaways long, correct?

@rafaelgomesxyz rafaelgomesxyz changed the title cache for giveaway extractor isn't working Giveaway Extractor: fix bug that does not display cache for trains with less than 50 giveaways Jun 20, 2019
@at46
Copy link
Author

at46 commented Jun 20, 2019

You're right. For trains/lists with more than 50 giveaways the cache works fine with 8.3.15.

@at46
Copy link
Author

at46 commented Jun 28, 2019

The cache is now displayed with 8.3.16 but enter button and game categories are missing unless I extract it again. Shall I open a new bug report for that?

@rafaelgomesxyz
Copy link
Owner

Yes, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants