Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove text from SG sync #186

Closed
gizellos opened this issue Nov 13, 2017 · 20 comments
Closed

Remove text from SG sync #186

gizellos opened this issue Nov 13, 2017 · 20 comments

Comments

@gizellos
Copy link

In the classic SG sync, there is text from ESGST sync - "By selecting a number X in the dropdown menu next to each data other than 0, you are enabling automatic sync for that data (which means the data will be synced every X days)."

(As you can see below, there is also an error which I have never seen before. I am logged to Steam. I have had it a few hours - since update to 7.7.4 so I am not sure if it is the steam API)

2017-11-13_024433

@Old-Nick
Copy link

I'm also getting the error message (I think only since installing the 7.7.4 update). In my case I know the Steam API side of things is working as I have a few other scripts that use it and they are fine (Do You Even Play, Bro?, Did They Even Play? and RaChart Enhancer).

@rafaelgomesxyz
Copy link
Owner

Can you go here: http://store.steampowered.com/dynamicstore/userdata And see if everything looks fine?

@rafaelgomesxyz rafaelgomesxyz changed the title Redundant text in SG sync Remove text from SG sync Nov 15, 2017
@rafaelgomesxyz rafaelgomesxyz added this to the 7.7.5 milestone Nov 15, 2017
@gizellos
Copy link
Author

I am not sure. I can see lots of numbers there but a lot of them are duplicates.

2017-11-15_205104

@rafaelgomesxyz
Copy link
Owner

rafaelgomesxyz commented Nov 15, 2017

Is there anything in rgOwnedApps: [] or is the [] empty? Try forcing a refresh to see if more stuff appear (Ctrl + F5).

@gizellos
Copy link
Author

Yes, there is. I saved the results here.

@rafaelgomesxyz
Copy link
Owner

Hm, it should be working then, you're still getting the error? I cannot reproduce this at all.

@gizellos
Copy link
Author

Yes, unfortunately, I am.

@rafaelgomesxyz
Copy link
Owner

rafaelgomesxyz commented Nov 15, 2017

Can you find this line: if (storeJson && storeJson.rgOwnedApps.length > 0) { and add console.log(storeResponse, storeJson); before it, then check the console?

@gizellos
Copy link
Author

I have nothing in console. Did I put it well there?

2017-11-16_153119

@rafaelgomesxyz
Copy link
Owner

Yes, did you check the console after syncing?

@gizellos
Copy link
Author

Yes, I checked console for both - the normal SG page and the page in the background And to be sure that it was loaded correctly, I also put console.log("test"); after it and appeared normally.

@rafaelgomesxyz
Copy link
Owner

Try separating the two: console.log(storeResponse); console.log(storeJson);

@gizellos
Copy link
Author

There is something. But the log is quite big. Is it enough for you like this?

2017-11-16_155444

@rafaelgomesxyz
Copy link
Owner

I do not understand that at all. There is clearly a storeJson file and the rgOwnedApps length is clearly more than 0, so I don't know why the condition is failing.

Can you try this: console.log(storeJson.rgOwnedApps.length); console.log(storeJson && storeJson.rgOwnedApps.length > 0);

@rafaelgomesxyz
Copy link
Owner

Ahh, I think I got it. You have an alt account set, right? I think that's it.

@gizellos
Copy link
Author

Yes, I have set an alt account.

The error is:

Error in event handler for (unknown): TypeError: Cannot read property 'rgOwnedApps' of undefined
    at continueGameSync (chrome-extension://jcipimoeegokakknfckimajbaddijmig/esgst.js:9026:23)
    at chrome.runtime.sendMessage.response (chrome-extension://jcipimoeegokakknfckimajbaddijmig/esgst.js:34970:17)

@gizellos
Copy link
Author

gizellos commented Nov 16, 2017

Plus this:

2023
true

@rafaelgomesxyz
Copy link
Owner

rafaelgomesxyz commented Nov 16, 2017

Will be fixed in the next version.

By the way, I don't know if you know this, but if you want to already start using the next version you can download the .zip at any moment. That works like a dev channel, while the public channel only gets updates once per week or so.

So if you don't want to wait to have access to the new features and bug fixes, you can use the dev channel.

@gizellos
Copy link
Author

That's cool, I didn't know that. Thanks for the tip.

BTW: how can I tell if an error will be in the normal console or in the console of the page on background?

@rafaelgomesxyz
Copy link
Owner

Basically only errors related to requests appear in the background page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants