Improvements/Issues dump

[lionirdeadman]

Broken :

• Add Bookmark buttons look broken
• Add Search engine option from address bar looks broken
• Extensions like feeds use dark font on dark backgrounds
• Volume button too close to X button
• Bookmark animation is broken
• Dropdown selected tab with blue line gets obscured when hovering

Improvements :

• Scrollbar theming (it's not dark on dark mode and doesn't act like GTK programs)
• Find view could be changed to be more similar to Epiphany's and other gnome programs
• Results Not connected to URL bar and no limit to height like Epiphany has
• Certificate information theming
• Permission request buttons theming
• Download overview theming

I didn't create an issue for each since I thought it'd be be too much

[rafaelmardojai]

@lionirdeadman Thanks for reporting this.
Broken stuff will be fixed this days.

Theming for FF popovers like download, site information, permission request, extension install, etc will come soon.
Scrollbar theming was tricky and more to mimic GNOME overlay scrolling, but i will try to fix it.

With "Results Not connected to URL bar and no limit to height like Epiphany has" do you mean what matching-autocomplete-width.css does?
With "Find view" do you mean the Find in page feature?

[lionirdeadman]

With "Results Not connected to URL bar and no limit to height like Epiphany has" do you mean what matching-autocomplete-width.css does?

Yes, I use it but unfortunately if you added more search results (using browser.urlbar.maxRichResults) to replicate what Epiphany offers, then it just goes down and never stops to make it scrollable like Epiphany. Also, it aligns perfect with tabs in the theme while Epiphany doesn't have that small gap in between.

With "Find view" do you mean the Find in page feature?

Yeah.

[rafaelmardojai]

What value do you have set in browser.urlbar.maxRichResults?

[lionirdeadman]

I have it set to an (absurd) 50. I'm unsure how many results Epiphany has.

[rafaelmardojai]

Try last commit. I added a max-height and scrollbar.

[lionirdeadman]

I would make that 30vh instead of 80 is closer to what Epiphany has. Also, is it possible to move the view when the selected item is out of view? 🤔

Volume button issue isn't fixed unless you've not commited the change :p

[rafaelmardojai]

Please, check list progress and test latest commits.
I'm moving Scrollbar theming to a new issue due to implementation difficulties.

[lionirdeadman]

Find view could be changed to be more similar to Epiphany's and other gnome programs

Actually, I meant if it were up and centered although, the padding is nice.

And you didn't say if it were possible to move the view to the selected item in the address results, it'd be quite useful.

The other things though, yup, nicely done.

[rafaelmardojai]

Actually, I meant if it were up and centered although, the padding is nice.

I centered it, but introduced some issues with the matches label, i will try something later.

And you didn't say if it were possible to move the view to the selected item in the address results, it'd be quite useful.

Looks like it's not possible. Firefox don't expect scrolling there, so can be an upstream bug. No way to fix it with CSS.

[lionirdeadman]

Looks like it's not possible. Firefox don't expect scrolling there, so can be an upstream bug. No way to fix it with CSS.

Yeah, makes sense, I'll open a bug then.

[rafaelmardojai]

@lionirdeadman Findbar is up and centered. Check last commit.

[lionirdeadman]

The count seems to be gone now and perhaps the "highlight all", "match Case" and such could be moved to the right? Otherwise, nice.

[rafaelmardojai]

Checkout last commit. ;)

[lionirdeadman]

Looks pretty good 👌

[rafaelmardojai]

Can you send me the link to install feeds extension?

[lionirdeadman]

There : https://addons.mozilla.org/en-US/firefox/addon/feed-preview/

Although, I'm sure applications which use the same mechanism are also affected.

[lionirdeadman]

It seems now that Feeds always shows as active with a white font. 🤔

[rafaelmardojai]

Can you attach screenshot?

[lionirdeadman]

This is how it shows even though there's no feeds available, usually it had a slightly darker font.

This is the original problem which happens when it can find a feed.

[rafaelmardojai]

Disabled button bug fixed.

Looks like Feeds don't implements regular Firefox popover. I can't get how it behaves.
I'm going to install other extensions to test.

[rafaelmardojai]

I'm closing this issue. Main improvements/issues were implemented and fixed.