Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing optoin to enable/disable colored URL bar in private browsing #21

Closed
johnfactotum opened this issue Jul 8, 2019 · 8 comments
Closed

Comments

@johnfactotum
Copy link

The option is referenced here:

* If you are using it, you might wanna enable the next feature too. Also you

The "next feature" referenced here was "Replace the private browsing indicator with a colored URL bar", but is currently missing.

@rafaelmardojai
Copy link
Owner

I will fix that line. Colored URL bar in private browsing is enable by default.

@johnfactotum
Copy link
Author

Will you provide an option to disable it? Personally I find the colored URL bar a bit distracting. Or perhaps change it to something more subtle?

@rafaelmardojai
Copy link
Owner

GNOME Web use some blue on headerbar elements in private browsing, we can go that way.

@rafaelmardojai
Copy link
Owner

I have implemented an icon on headerbar background as private browsing indicator. Looks good to you?

Captura de pantalla de 2019-07-08 12-22-02

@lionirdeadman
Copy link

lionirdeadman commented Jul 9, 2019

This only appears in blank spaces (so if you don't use flex items, it won't work) and doesn't work when it has a small width as a result.

Is it possible to make it go through buttons and the search bar but with more transparency? This is what Epiphany does.

@rafaelmardojai
Copy link
Owner

rafaelmardojai commented Jul 9, 2019

I know, but that was the only way i found to put it there.
Let me look for a better implementation...

@rafaelmardojai
Copy link
Owner

Epiphany can do it right, because it has a static amount of buttons in headerbar.

@rafaelmardojai
Copy link
Owner

I can try to prevent it to hide when is on small width.
But, how many users running this theme are not using flex items on the sides of urlbar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants