Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMS ?? #161

Closed
HwaiHo-0552 opened this issue Jan 15, 2022 · 3 comments
Closed

NMS ?? #161

HwaiHo-0552 opened this issue Jan 15, 2022 · 3 comments

Comments

@HwaiHo-0552
Copy link

As shown in Evaluator.py, the row 114 to 120, TP is the highest class socre bbox, and other bbox are set as FP.
I think it may makes error in recall and precision.
i.e. there is pred bbox named A=['dog', 'class score=90%', 'x', 'y', 'w', 'h', IOU=95%],
another pred bbox named B_1=['dog', 'class score=96%', 'x', 'y', 'w', 'h', IOU=89%]
A and B_1 are all belongs to possitive sample.
if we set B_1 as TP, meanwhile set A as FP, this will lead error to recall and precision.
SO, should set NMS to save B_1 as one pred bbox, then compute TP FP TN FN ??

@rafaelpadilla
Copy link
Owner

rafaelpadilla commented Jan 16, 2022

Hi @digitalized-hfut

In this example, as you realized, if both detections (A and B_1) are provided, A will be FP and B_1 is TP.

That's why applying NMS or any other approach to eliminate such undesired detection is a task of the object detection model. It is not a task of the evaluator.

Hope that answers your doubt.

Regards,
Rafael

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@HwaiHo-0552
Copy link
Author

Hi @rafaelpadilla

Got it. Thank you for your code.

best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants