Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I created updates #36

Closed
b-mi opened this issue Jun 16, 2017 · 6 comments
Closed

I created updates #36

b-mi opened this issue Jun 16, 2017 · 6 comments

Comments

@b-mi
Copy link
Contributor

b-mi commented Jun 16, 2017

This is nice library.
I modified it:

  • support .net framework 4
  • add ClearMessages method (all or some message). It allow clear all visible messages, or disable duplicity of notifications - hiding old notification before show new notification with the same message
  • add GetMessage() method - getting text
  • add CanClose option for single notidication - disable automatic close of it
  • add Action option for Notidfication
  • add FreezeOnMouseEnter notification option - Notification do not hide if user enter it with mouse
  • Notifications are Queued, no one is simple closed. Queued notification are show after another notification are closed / hidden
  • fixed problem with MaximumNotificationCount
  • add Tag property to MessageOptions
  • added GetOptions method
  • moved MesageOptions to Core project

Do someone want these updates, can I somewhere post them?

@rafallopatka
Copy link
Owner

Hi,

Thanks for contribution !:) Could you share the code with me via pull request? I would like to see your changes and include it in current branch.

Best regards!

@b-mi
Copy link
Contributor Author

b-mi commented Jun 17, 2017

I sent updates by github desktop app. I do not use github, so I'm not sure updates was really sent. If not, please give me know. Updates list are in checkin description, BasicUsageExamle project show new abilities

@rafallopatka
Copy link
Owner

Hi,

Thanks! I'm checking it, I will let you know what next :) Could you investigate how to create pull requests in github, I think this would be helpfull to merge your changes into my library.

Best regards.

@rafallopatka
Copy link
Owner

This is huge, great job! Definitely it's worth to include your changes into this library.
Please create a pull request, it will be easier to merge it.

@b-mi
Copy link
Contributor Author

b-mi commented Jun 17, 2017

Thanks, I created a pull request, I hope correctly.

@rafallopatka
Copy link
Owner

Yes it's correct, I merged your changes, before I release new nugget I will make some additional changes and bug fixes. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants