-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardcoded localhost #1
Comments
Good catch, thanks! I'll fix that asap |
Fixed: 13b7e9c However, it leads me to another concern, hardcoded port. I would like to minimize dependencies and not use any templating engine for that. Any suggestions? |
I agree with your minimal dependency approach. I would fs.readFileSync the html file and then replace {{PORT}}, {{TITLE}} tokens using a simple handlebars like regex: http://stackoverflow.com/a/17304898 |
Thanks. I've just added this, seems to be working fine: d30faec |
Remove unnecessary dot from config object
The socket.io connection is hardcoded to localhost:
https://github.com/RafalWilinski/express-status-monitor/blob/master/index.html#L139
The text was updated successfully, but these errors were encountered: