Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded localhost #1

Closed
shauntrennery opened this issue Aug 17, 2016 · 4 comments
Closed

Hardcoded localhost #1

shauntrennery opened this issue Aug 17, 2016 · 4 comments

Comments

@shauntrennery
Copy link

The socket.io connection is hardcoded to localhost:

https://github.com/RafalWilinski/express-status-monitor/blob/master/index.html#L139

@RafalWilinski
Copy link
Owner

Good catch, thanks! I'll fix that asap

@RafalWilinski
Copy link
Owner

Fixed: 13b7e9c

However, it leads me to another concern, hardcoded port. I would like to minimize dependencies and not use any templating engine for that. Any suggestions?

@shauntrennery
Copy link
Author

I agree with your minimal dependency approach. I would fs.readFileSync the html file and then replace {{PORT}}, {{TITLE}} tokens using a simple handlebars like regex: http://stackoverflow.com/a/17304898

@RafalWilinski
Copy link
Owner

Thanks. I've just added this, seems to be working fine: d30faec

RafalWilinski pushed a commit that referenced this issue Aug 21, 2016
Remove unnecessary dot from config object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants