You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's not disastrous, but the following currently happens on Julia 1.9:
WARNING: Method definition constructorof(Type{var"#s1"} where var"#s1"<:(StaticArraysCore.SArray{Tuple{S}, T, 1, S} where T where S)) in module StaticArraysExt at C:\Users\XXX\.julia\packages\ConstructionBase\VB0co\ext\StaticArraysExt.jl:12 overwritten in module ConstructionBaseExtras at C:\Users\XXX\.julia\packages\ConstructionBaseExtras\cy4E1\src\staticarrays.jl:8.
** incremental compilation may be fatally broken for this module **
and a few other warnings like that; all caused by the same underlying issue as far as I can tell.
It's caused by having loaded StaticArrays.jl, which triggers the corresponding extension in ConstructionBase.jl, then ModelParameters.jl loads ConstructionBaseExtras.jl, which overwrites the method already defined by the extension in ConstructionBase.jl.
I can give it a try to fix this, but if someone else is already on it, then I'll just wait of course. I would probably have to rely on Requires.jl to make things compatible for Julia versions <1.9, though?
ConstructionBaseExtras.jl was a stopgap to make StaticArrays.jl work until we got weak dependencies, which land in 1.9. So it will be archived. It's not really a necessary dependency here, just stops one of the main sources of errors.
So we can just stop depending on it, and everything will keep working on 1.9. On 1.6-1.8 people will have to load it manually.
So you can just delete the ConstructionBaseExtras.jl dep completely, if you want to PR. No Requires.jl needed.
It's not disastrous, but the following currently happens on Julia 1.9:
and a few other warnings like that; all caused by the same underlying issue as far as I can tell.
It's caused by having loaded StaticArrays.jl, which triggers the corresponding extension in ConstructionBase.jl, then ModelParameters.jl loads ConstructionBaseExtras.jl, which overwrites the method already defined by the extension in ConstructionBase.jl.
I can give it a try to fix this, but if someone else is already on it, then I'll just wait of course. I would probably have to rely on Requires.jl to make things compatible for Julia versions <1.9, though?
@rafaqz, would that be fine with you?
The text was updated successfully, but these errors were encountered: