Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for options in requestFullscreen() #25

Open
lguminski opened this issue Apr 2, 2021 · 2 comments
Open

support for options in requestFullscreen() #25

lguminski opened this issue Apr 2, 2021 · 2 comments

Comments

@lguminski
Copy link

this is a very useful library. Yet I noticed that in Android Chrome it fails to hide the navigation bar. In order to do that, navigationUI: 'hide' option needs to be provided to requestFullscreen(), but it is not possible to pass through fscreen.

More information on options here

@rafgraph
Copy link
Owner

rafgraph commented Apr 2, 2021

I think adding an options argument to fscreen.requestFullscreen makes sense.

Until then you should be able to use fscreen.requestFullscreenFunction(element)(options) to pass in options.

@lguminski
Copy link
Author

Until then you should be able to use fscreen.requestFullscreenFunction(element)(options) to pass in options.

and this basically solves my problem. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants