Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question : Add Fastapi-users library for authentication ? #2

Closed
sorasful opened this issue Nov 24, 2021 · 3 comments
Closed

Question : Add Fastapi-users library for authentication ? #2

sorasful opened this issue Nov 24, 2021 · 3 comments

Comments

@sorasful
Copy link

I was asking myself if this would be a good idea to use this library :

https://github.com/fastapi-users/fastapi-users

Since it supports a lot of features out of the box, including oauth ...

What do you think ?

@sorasful
Copy link
Author

Hmm, I finished reading the README.md and I understand your point of view, you want to keep it simple, without third party.

I'm closing it, i'll reopen if you think we should do something about adding an option or something.

@rafsaf
Copy link
Owner

rafsaf commented Nov 24, 2021

@sorasful

That is definitely an option, currently user is prompted to enter the project_name only ;) I can not see any contraindications to add something optional, maybe one that it takes a bit of exercise, messing with if stmts in some files, or just keeping two versions for those files. I just didn't want crazy setup by default (and didn't need it really).

Let me look at it this or next weekend.

If you have any thoughts, feel free to provide eg. repo based on this template with fastapi-users included, kicking it later into template is just an implementation detail.

@rafsaf
Copy link
Owner

rafsaf commented Jan 30, 2022

Since FastAPI Users started to support SQLAlchemy few weeks ago (and dropped support for databases library), I've added option to choose new template based on FastAPI Users in this repository.

@rafsaf rafsaf closed this as completed Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants