rescale() crashes if given negative w / h values

[fire-eggs]

In YAIV, inadvertently trying to zoom below 0%. This caused negative w or h values being sent to fl_imgtk::rescale.

Resulted in a crash rather than the expected nullptr return.

[rageworx]

Dear Kevin,
I'd seen this issue too late, sorry.
I will try to check that issue, anyway did you know rescale parameters are only "unsigned" ?
I think zero size may protect by this line.

fl_imgtk/src/fl_imgtk.cpp

Line 1888 in 51f162b

if ( ( img != NULL ) && ( w > 0 ) && ( h > 0 ) )

You mean below 0%, is it going to negative value as integer ?
Maybe you didn't check signed to unsigned value, it may be a reason of crash for too large image size.
Regards, Raph.

[rageworx]

Maybe ... is it better if limit maximum size of resized ?
Like ... #define MAX_IMAGE_WH_SIZE 1024000 ?

[fire-eggs]

I'd seen this issue too late, sorry.

Not a crisis, just informational. A flaw in my UI, incorrectly sending a signed int to the resize function.

Glad to see you're still about - hadn't heard from you for a while ...

[rageworx]

New project almost reached to the end for now.
So I couldn't have make time for response for a while.
Thanks !

[rageworx]

Need to overflow case to prevent failure case.