Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor optimizer to use keras optimizer #1

Closed
raghakot opened this issue Dec 25, 2016 · 2 comments
Closed

Refactor optimizer to use keras optimizer #1

raghakot opened this issue Dec 25, 2016 · 2 comments

Comments

@raghakot
Copy link
Owner

raghakot commented Dec 25, 2016

Currently we are using custom numpy logic for rmsprop. Keras already provides optimizers that we should leverage. It is also much much better to run updates on GPU instead transitioning back and forth to numpy.

This has bigger implications..everything in numpy needs to be converted to use tensors. Ex: modifiers module.

@raghakot
Copy link
Owner Author

Queries are being tracked here: keras-team/keras#4746

@raghakot
Copy link
Owner Author

raghakot commented May 8, 2017

It is not possible to use keras optimizer with an input placeholder as we cannot compute the gradient of placeholder wrt loss. The only other alternative is to modify model graph which is pretty hairy. Closing this as we wont go this route.

@raghakot raghakot closed this as completed May 8, 2017
@raghakot raghakot removed the ready label May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant