Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atrribute credits in Readme #49

Closed
jacobgil opened this issue Jun 30, 2017 · 3 comments
Closed

Atrribute credits in Readme #49

jacobgil opened this issue Jun 30, 2017 · 3 comments

Comments

@jacobgil
Copy link

Hi,
I've been following this project code from the beginning and think it's a nice effort.

Some of the ideas/code here were assisted with a few repositories of mine.
Specifically,
https://github.com/jacobgil/keras-grad-cam
https://github.com/jacobgil/keras-filter-visualization
And now with the recent self driving car demo,
https://github.com/jacobgil/keras-steering-angle-visualizations

I think it would be fair if you attribute/give credit for this in the Readme.

Thanks,
Jacob

@raghakot
Copy link
Owner

Actually, I was inspired by keras blog on filter visualization. I did find your self driving blog while working on an issue that requested a way to visualize self driving car, so I will give credit for that.

PS: I have some questions on that if you have time to discuss it. My implementation is actually a little different than yours.

@jacobgil
Copy link
Author

Sure I"l be glad. Email me to jacob.gildenblat@gmail.com

@raghakot
Copy link
Owner

I added credits here: https://github.com/raghakot/keras-vis/blob/master/applications/self_driving/README.md

Let me know if you feel that i am missing attribution elsewhere.
PS: Would love it if you contribute PRs to this project. There are several implementations linked in the issues that are planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants