Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registeration forms #24

Closed
5 tasks
raghav4 opened this issue May 2, 2020 · 2 comments · Fixed by #27
Closed
5 tasks

Registeration forms #24

raghav4 opened this issue May 2, 2020 · 2 comments · Fixed by #27
Labels
forms frontend-ui Yearbook frontend improvement no-issue-activity Priority: High High Priority Task
Projects
[Archived] Yearbook: Ref 2020
Milestone
User Forms

Comments

@raghav4
Copy link
Owner

raghav4 commented May 2, 2020

Sign Up

Client Side

  • No request should be made until all the values are properly filled.
  • Check if the password matches beforehand.
  • Try using default validation error rather than using popup alert.
  • Add a loader while registration button is clicked.
  • Let the user know on the successful registration.
@raghav4 raghav4 added frontend-ui Yearbook frontend improvement labels May 2, 2020
@raghav4 raghav4 added this to the User Forms milestone May 9, 2020
@raghav4 raghav4 moved this from To do to In progress in [Archived] Yearbook: Ref 2020 May 9, 2020
@raghav4 raghav4 added the Priority: High High Priority Task label May 9, 2020
@raghav4 raghav4 linked a pull request May 11, 2020 that will close this issue
Fixed Stale codes, added routes, separated components #27
Merged
@raghav4 raghav4 reopened this May 11, 2020
@raghav4
Copy link
Owner Author

raghav4 commented May 11, 2020

Fixed

  • Login Form
  • Update Details Form
  • Signup form

@raghav4 raghav4 pinned this issue May 11, 2020
@raghav4 raghav4 added the forms label May 12, 2020
@raghav4 raghav4 unpinned this issue May 12, 2020
@github-actions
Copy link

Stale issue message

@raghav4 raghav4 reopened this Jul 19, 2020
@raghav4 raghav4 moved this from In progress to Done in [Archived] Yearbook: Ref 2020 Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
forms frontend-ui Yearbook frontend improvement no-issue-activity Priority: High High Priority Task
Projects
No open projects
[Archived] Yearbook: Ref 2020
  
Done
Milestone
User Forms
Development

Successfully merging a pull request may close this issue.

Fixed Stale codes, added routes, separated components raghav4/Yearbook
1 participant
@raghav4