Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Normalize transform #20

Open
raghavmecheri opened this issue Nov 19, 2020 · 0 comments
Open

Fix Normalize transform #20

raghavmecheri opened this issue Nov 19, 2020 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@raghavmecheri
Copy link
Owner

Describe the bug
I've hardcoded this entire function call -- it's specific to a 3-dimensional array, where the innermost element has 3 channels. This is probably not a good idea at all.

To Reproduce
There's no bug at the moment, so this is redundant. I'm sure this'll lead to a load of different bugs if not fixed though.

Expected behavior

  • Generalises to different sized input arrays
  • Maybe something more efficient than 3 nested loops?

Screenshots
N/A

Desktop (please complete the following information):
N/A

Additional context
Ref:

_norm = (arr, mean, std) => {

@raghavmecheri raghavmecheri added enhancement New feature or request help wanted Extra attention is needed labels Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant