Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly Clippy Issues #3

Closed
gkelly opened this issue Nov 26, 2022 · 1 comment
Closed

Nightly Clippy Issues #3

gkelly opened this issue Nov 26, 2022 · 1 comment

Comments

@gkelly
Copy link
Contributor

gkelly commented Nov 26, 2022

    Checking quorum v0.1.0 (/home/gkelly/p/quorum)
error: pub(crate) function inside private module
  --> src/encrypt.rs:12:1
   |
12 | pub(crate) fn encrypt(args: &Encrypt) -> Result<()> {
   | ----------^^^^^^^^^^^
   | |
   | help: consider using: `pub`
   |
note: the lint level is defined here
  --> src/main.rs:3:9
   |
3  | #![deny(clippy::nursery)]
   |         ^^^^^^^^^^^^^^^
   = note: `#[deny(clippy::redundant_pub_crate)]` implied by `#[deny(clippy::nursery)]`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pub_crate

error: pub(crate) function inside private module
  --> src/encrypt.rs:34:1
   |
34 | pub(crate) fn decrypt(args: &Decrypt) -> Result<()> {
   | ----------^^^^^^^^^^^
   | |
   | help: consider using: `pub`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pub_crate

error: pub(crate) function inside private module
 --> src/quorum.rs:9:1
  |
9 | pub(crate) fn generate(args: &Generate) -> Result<()> {
  | ----------^^^^^^^^^^^^
  | |
  | help: consider using: `pub`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pub_crate

error: pub(crate) function inside private module
  --> src/quorum.rs:36:1
   |
36 | pub(crate) fn recover_secret(share_paths: Vec<String>, threshold: u8) -> Result<[u8; 32]> {
   | ----------^^^^^^^^^^^^^^^^^^
   | |
   | help: consider using: `pub`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pub_crate

error: could not compile `quorum` due to 4 previous errors
@ragona
Copy link
Owner

ragona commented Nov 26, 2022

Should be fixed here; swapped those to just use pub and also changed the command structs to be public.

(Though I admit I didn't swap to the nightly channel and check myself 😅.)

@ragona ragona closed this as completed Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants