Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsafe macros break build #15

Closed
jonahbron opened this issue Oct 23, 2019 · 2 comments
Closed

Unsafe macros break build #15

jonahbron opened this issue Oct 23, 2019 · 2 comments

Comments

@jonahbron
Copy link
Contributor

Looks like the commit that went in yesterday (0aef1a6) fixed one layer of the issue, but there seem to be remaining issues. Here's what I got when trying to build today:

error[E0133]: call to unsafe function is unsafe and requires unsafe function or block
  --> /home/jonah/Projects/avr-hal/chips/atmega328p-hal/src/spi.rs:31:1
   |
31 | / avr_hal::impl_spi! {
32 | |     pub struct Spi {
33 | |         peripheral: crate::atmega328p::SPI,
34 | |         pins: {
...  |
39 | |     }
40 | | }
   | |_^ call to unsafe function
   |
   = note: consult the function's documentation for information on how to avoid undefined behavior
   = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
@Rahix
Copy link
Owner

Rahix commented Oct 24, 2019

I think you have already fixed this in commit bd13c70 ("Wrapped newly unsafe function in an unsafe block")?

@jonahbron
Copy link
Contributor Author

Yeah I think so, I've had no trouble compiling recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants