Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve README.md #11

Merged
merged 7 commits into from Sep 24, 2021
Merged

Conversation

MichaelCurrin
Copy link
Contributor

@MichaelCurrin MichaelCurrin commented Sep 23, 2021

I covered HTML to Markdown mostly. And indented code neatly in bullet points.

Converted a bullet list into a numbered list.

I added a link to the big GIF goes to the website when clicked.

Fixed some typos.

Made all the H1s into H2s except for the main heading. It is bad practice to have more than one H1 on a page. Linters / accessibility checkers will complain.

@rahulbanerjee26
Copy link
Owner

Hey @MichaelCurrin! Thanks for the PR! Could you please add your name under the 'Contributors' section? I will merge the PR after that is done

@MichaelCurrin
Copy link
Contributor Author

MichaelCurrin commented Sep 24, 2021

Done!

I also fixed a mistake I made.

And also improved Contributing section. The features and issues sections made sense to be combined under a heading. And the bit about PRs was not clear. The set origin bit is not a needed and is confusing if you don't even have a clone yet.

@rahulbanerjee26 rahulbanerjee26 merged commit 6538776 into rahulbanerjee26:main Sep 24, 2021
@rahulbanerjee26
Copy link
Owner

Thanks for your contribution, Michael!

@MichaelCurrin MichaelCurrin deleted the patch-1 branch September 24, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants