Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I want to enter an address in a non-checksummed format #238

Closed
christianbrb opened this issue Aug 6, 2019 · 2 comments
Closed

I want to enter an address in a non-checksummed format #238

christianbrb opened this issue Aug 6, 2019 · 2 comments

Comments

@christianbrb
Copy link
Contributor

User Story

As Chris, I want to enter an address in a non-checksummed format so that I don't have to convert my non-checksummed address to a checksummed address

see: https://web3js.readthedocs.io/en/v1.2.0/web3-utils.html#tochecksumaddress

Acceptance criteria

Tasks

@christianbrb christianbrb added this to the Product Backlog milestone Aug 6, 2019
@andrevmatos
Copy link
Contributor

andrevmatos commented Aug 9, 2019

I think that may be a problem. Checksummed addresses were introduced in ethereum/EIPs#55 to avoid users commiting typos or partial paste errors for addresses on UIs. They can always go to the given address in e.g. https://etherscan.io to check the account and from there copy the checksummed address they've verified as the intended one.

If we really want to support non-checksummed addresses, I'd say to only support all-lower or all-uppercase addresses, and with a small warning under the input box that this address is not checksummed and a link to the EIP/docs with the importante of prefering checksummed source addresses.

@christianbrb
Copy link
Contributor Author

According to the feedback, I'll close the issue

Thanks @ulope and @andrevmatos :)

@andrevmatos andrevmatos removed this from the Product Backlog milestone Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants