Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deposit to and withdraw from UDC #556

Closed
manuelwedler opened this issue Oct 16, 2020 · 3 comments · Fixed by #606
Closed

Deposit to and withdraw from UDC #556

manuelwedler opened this issue Oct 16, 2020 · 3 comments · Fixed by #606
Assignees
Labels

Comments

@manuelwedler
Copy link
Contributor

manuelwedler commented Oct 16, 2020

Is your feature request related to a problem? Please describe.

There should be a way to deposit to the UDC directly from the WebUI. Having the withdraw functionality would also be nice.

Describe the solution you'd like

There could be button close to the UDC balance in the header which opens a pop up for managing the UDC funds. In the pop up the user could deposit and withdraw.

Triggering the transaction

There are two options for the deposit:

  1. The deposit transaction could be done from the raiden client and the account it controls. This would need a new API call. (API endpoint for UDC contract to deposit and withdraw RDN tokens  raiden#5497)
  2. It could also be done via MetaMask from a different account.

The withdraw can't be done on the behalf of another account. So for it only an API call is possible with the current version of the contracts.

@czepluch
Copy link

czepluch commented Jan 4, 2021

I would love to see this being prioritized. We often get questions about how to deposit to the UDC!

@manuelwedler manuelwedler self-assigned this Jan 13, 2021
@manuelwedler
Copy link
Contributor Author

manuelwedler commented Jan 22, 2021

We decided to have the respective API calls in the client (raiden-network/raiden#5497) and not use MetaMask. The reasion is we would need it any way for the withdraw and do not have any transactions triggered by MetaMask yet and want to continue like this for consistency.

@sashseurat sashseurat self-assigned this Jan 29, 2021
@sashseurat
Copy link

Draft with quick click-dummy is here:
https://www.figma.com/proto/Q5sJRXwMH3ydOTzQlchO0T/WebUI-UDC-Management-UXUI?node-id=511%3A496&viewport=-33%2C716%2C0.12004529684782028&scaling=scale-down

Also reviewed with Manuel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants