Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Automatic models folder deletion after re-installation #40

Closed
dbouget opened this issue May 4, 2023 · 2 comments
Closed

Bug: Automatic models folder deletion after re-installation #40

dbouget opened this issue May 4, 2023 · 2 comments
Assignees
Labels
bug Something isn't working
Projects

Comments

@dbouget
Copy link
Collaborator

dbouget commented May 4, 2023

On Ubuntu and Mac, the .raidionics is not deleted during the installation process.

An automatic deletion of the Models folder should be performed, based on the software version, to prevent issues due to old models still existing on disk but likely not forward-compatible.

@dbouget dbouget added the bug Something isn't working label May 4, 2023
@dbouget dbouget self-assigned this May 4, 2023
@dbouget dbouget added this to To do in v1.3.0 via automation May 4, 2023
@andreped andreped changed the title Automatic models folder deletion after re-installation Bug: Automatic models folder deletion after re-installation Sep 27, 2023
@andreped
Copy link
Member

andreped commented Sep 27, 2023

@dbouget I thought you added a fix for this when the program is launched the first time after installation?

For UNIX-based system, there isn't a way to remove this folder, AFAIK. At least on macOS there is no uninstall script. App bundles are deleted by deleting the bundle itself manually (right click + remove). For Ubuntu we could make such a method, but I do not see a point in doing it, if it doesnt work for macOS. Best is just to detect if the program is launched the first time, and then from the program we can delete the folder, which I believe you are doing now, or?

@dbouget
Copy link
Collaborator Author

dbouget commented Sep 28, 2023

We can leave the automatic removal of the models folder upon installation for Windows only.

In general, there is an option in the Settings panel to manually request a purge of the models folder (by clicking the trash bin icon).

@dbouget dbouget closed this as completed Sep 28, 2023
v1.3.0 automation moved this from To do to Done Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants