We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the second term from https://github.com/vitchyr/rlkit/blob/master/rlkit/torch/distributions.py#L43-L44 with the equation from https://github.com/tensorflow/probability/blob/master/tensorflow_probability/python/bijectors/tanh.py#L73 .
That is, replace torch.log(1 - value * value + self.epsilon with 2. * (log(2.) - pre_tanh_value - softplus(-2. * pre_tanh_value)).
torch.log(1 - value * value + self.epsilon
2. * (log(2.) - pre_tanh_value - softplus(-2. * pre_tanh_value))
The text was updated successfully, but these errors were encountered:
Implemented in c1e9ec6.
Sorry, something went wrong.
No branches or pull requests
Replace the second term from https://github.com/vitchyr/rlkit/blob/master/rlkit/torch/distributions.py#L43-L44 with the equation from
https://github.com/tensorflow/probability/blob/master/tensorflow_probability/python/bijectors/tanh.py#L73 .
That is, replace
torch.log(1 - value * value + self.epsilon
with2. * (log(2.) - pre_tanh_value - softplus(-2. * pre_tanh_value))
.The text was updated successfully, but these errors were encountered: