Bugs/Errors found during testing

[anikalindtner]

MUST FIX

• can't submit a completely filled out application, get an error that the team should have at least one mentor
• cost of living link-> faulty
• add buttons "next" and "back" to bottom of page, so indicate that you have to go through the next tabs in order to go through application 
• check validity (assigned to @michaelem, improved in a friendlier application draft form #409)
  • should only be visible on last tab page
  • should SAVE & check
• doesn't save skill level (Radio buttons in application form do not correspond to user profile data #192)
• doesn't give error message if not filled out:
  • what do you want to achieve
  • how did you get into programming
  • how much money do you need (maybe just delete the "--" field)
• can't change roles from e.g. student to coach: If I try to edit that team, changing anasofiapinho from student to coach or from coach to student, the mouse doesn't let me select.
• "Banking Information (1st student) can't be blank" -> field doesn't exist

TEXT (assigned to maria)

• "Some of the guidelines are specific to ruby, but most are language-agnostic." - needs to be changed
• "For how many months have you been learning the language of your chosen project?" - doesn't mention secondary project
• obligatory fields: state that all fields are obligatory
• "Tell us about your Rails Girls and community involvement."-> change to all initiatives
• "minimum money" error message shows when you don't fill out the OPTIONAL text field underneath.

UI: ERROR MESSAGE: (#408)

• "4 errors to go before you can apply:" <- this is invisible (red on red).
• error messages should tell you in which tab the info is missing
• error messages not as a summary, but in selected fields (some error messages are shown directly in the field, some are not. this is confusing)
• some of error messages refer to ‘1st student’ and '2nd student’, and some - to ‘student0’ and ‘student1’. it would be nice if all messages looked the same (e.g. refer to ‘1st student’ and '2nd student’)

ON THE FENCE

• add pagination (e.g. 2/4) to bottom of page to show which tab you are on
• if i go to edit my team, i have random team members filled in but no roles selected
• 750-1000 words for essay: add word count to text field?

TEXT

• "Since this is a self-guided program, how are you planning to work together?" -> this might need a bit more explanation. (in the works, see Add these markdown docs to the help section #410)
• 1st student: not explained, who is 1st who second <- hard to fix

NICE TO HAVE

• "Please don't mention your name, age, or current location." -> should be bolder, on top of the text field
• "my team" should be next to "my application" in menue
• show progress (3/10) (make tabs green/ red for errors)
• It makes more sense to open links to Help and Guides in a new tab (e.g. Application guide on the Application form).

TEXT

• ERROR MESSAGES: red / black can't read -> should be black on white with a red border or sth.
• "For volunteer teams only" -> confusing. text needs to be changed
• error message: should not be "please add another sutdent", but "please edit your team first"
• step by step process: 1. log in, then edit your team
• financial numbers: 1500+ is missing

[alicetragedy]

cost of living fixed: 49da743
error messages: removed banking info, added money, achieve, how did you get into programming f2a2115

[alicetragedy]

@anikalindtner this -> 8ab7e5e should at least make the flash messages (the "pretty" error or info boxes) more bearable by adding a small button that can be used to dismiss the message.

[anasofiapinho]

Nice to have:
The order in which the errors are listed is not the same as the form and that causes a bit of confusion.

images here: https://github.com/rails-girls-summer-of-code/organization/issues/129#issuecomment-196045760

[carpodaster]

can't change roles from e.g. student to coach: If I try to edit that team, changing anasofiapinho from student to coach or from coach to student, the mouse doesn't let me select.

That is WAI and is/was part of #205 + a85416d; the radio buttons are disabled.

[carpodaster]

doesn't save skill level (#192)

The skill level does get saved, it just doesn't pre-select the radio buttons. At least I can reproduce this problem locally now (which wasn't the case last year when we got all the bug reports). I'm still at a loss why that is so.

[carpodaster]

"my team" should be next to "my application" in menue

This, too, is subject to #380

[carpodaster]

show progress (3/10) (make tabs green/ red for errors)

This is quite a task and also quite brittle in respect to future changes. I wouldn't want to assign resources to it right now.

[carpodaster]

if i go to edit my team, i have random team members filled in but no roles selected

I think I need a more concrete example for that

[carpodaster]

add buttons "next" and "back" to bottom of page, so indicate that you have to go through the next tabs in order to go through application

I don't think we can add this. For example the 2nd tab is not really a "next" tab since a student cannot edit the fields of their pair.

[anikalindtner]

@carpodaster: if you click on "edit" you can see people added to your team that you didn't add. Like:

I know that this looks a bit different for me, since I'm also an organizer, but my pair (who's a friend of mine and not an organizer) could also see this.

• as for the "doesn't save skill level":
  I'm not sure I understand your answer, but this happens:
  I select my skill level like this:
  

After I click on "safe as draft", I get this:

[carpodaster]

@anikalindtner skill level issue: What I meant is that the underlying database record gets saved. The form just doesn't pre-select the value present in de DB

[carpodaster]

@anikalindtner Can you give me the ID of the team in question please? Or its direct URL?

[alicetragedy]

@carpodaster @anikalindtner it's weird, because for me, locally, it works. technology, how does it even.

[anikalindtner]

@carpodaster https://rgsoc-teams-staging.herokuapp.com/teams/1/edit

[alicetragedy]

@anikalindtner I just double-checked the info regarding your team in staging, and it seems like your team wasn't created yesterday, but it was created last year. So, I'm guessing that's why you have those roles in there — they were added last year to your team, and when you logged into the app you didn't create a new team but just added a student to your currently existing team. Could that be it?

[anikalindtner]

@alicetragedy ah yes! exactly! Hat tip ms sherlock <3

[carpodaster]

We are live!

[alicetragedy]

so are the bugs! they've been released into the wild 🎉

[anikalindtner]

I'd love to keep track of this. and if someone has a minute they can fix some of the bugs listed here.

[carpodaster]

@anikalindtner The must haves are fixed. I've commented on some of the others and among them are a few wontfixes (because they're not applicable).

For text corrections: suggestions for better wording are most welcome.

If there are items left in this list, please add them as new issues. It's a lot easier to keep track of an atomic issue than aggregate ones like this.

This said: we are currently a bit swarmed with issues and I'd rather have issues closed that are of no immediate concern than having our issue / feature request list grow over 5+ pages.

[alicetragedy]

will take another look at the text-based fixes and adding the link to the team in the navigation, but I think that's all we will be able to deal with this year (ie. no progress bar, no pagination because it doesn't make sense from a UX point of view).
as @carpodaster said I think immediate items can be added as new issues. the text-based corrections will be fixed today still by me, so no need to add them separately!

[anikalindtner]

awesome, laura thank you. feel free to close this then again after today.

[alicetragedy]

Note: "state that all fields are obligatory" is not required anymore because a) not all fields are obligatory and b) we have finally fixed all of the error fields, so everything is showing properly now.