Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release a new version that supports Rails 7.1 #249

Closed
evmorov opened this issue May 6, 2024 · 8 comments · Fixed by #251
Closed

Release a new version that supports Rails 7.1 #249

evmorov opened this issue May 6, 2024 · 8 comments · Fixed by #251

Comments

@evmorov
Copy link

evmorov commented May 6, 2024

Hello, I don't want to be annoying, but I'm curious about when a new version will be released. Previously, it was stated here:

once it's more stable we'll cut a release

It has been a month since then. Is it more stable now?

@mnovelo
Copy link
Collaborator

mnovelo commented May 7, 2024

We'd like to get the build pipeline to work (ideally via GitHub Action) and for the specs to pass before cutting a new version. Any help would be appreciated!

@andyundso
Copy link

I could help with the testing pipeline on GitHub Actions. I built a testing pipeline also with Appraisal against different Rails and Ruby versions over at https://github.com/simplificator/keycloak_oauth/blob/main/.github/workflows/tests.yml.

From what I can see, we would likely need to test the different combinations of:

  • Postgres / MySQL
  • Rails 6.1, 7.0, 7.1
  • Ruby 3.0, 3.1, 3.3 + JRuby 9.4.6.0 or newer (equals CRuby 3.1)

regarding MySQL: will you still support 5.7 (end of life since October 2023) or only 8.0+? what about MariaDB?

@mnovelo
Copy link
Collaborator

mnovelo commented May 7, 2024

Wow thank you so much @andyundso!

Re: MySQL, I don't work with it myself and have no means to test it in production, but if 5.7 is past its EOL, let's drop it. We'll only support MariaDB if someone is able to add it and help support it like has been started for trilogy

@andyundso
Copy link

well, then #250 should contain everything needed.

it just tests one version of Postgres (v14, since the Ubuntu Runner on GitHub Actions ships with the v14 version of the Postgres client). Also, the JRuby tests fail currently, not sure if those should be skipped for now or you want to merge the PR as-is.

@mrpasquini
Copy link
Contributor

I tracked down the jruby issues in today and added them to #251

@IanMcNelly IanMcNelly linked a pull request May 14, 2024 that will close this issue
@IanMcNelly
Copy link
Contributor

Merging #251 to resolve this issue because it has passing tests, parity for rails/ruby version coverage to #250, and doesn't introduce a new gem. The fix for the tests in JRuby is good from my point of view; since we're manipulating the resulting strings, we would never want the double quotes to be present

@IanMcNelly
Copy link
Contributor

Reopening until the release is actually available!

@IanMcNelly IanMcNelly reopened this May 16, 2024
@mnovelo
Copy link
Collaborator

mnovelo commented May 24, 2024

Released! https://rubygems.org/gems/ros-apartment

@mnovelo mnovelo closed this as completed May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants