You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Wouldn't it make sense to implement equality for Arel::Nodes ?
Or to be more specific to have a proper implementation of the hash function for Arel::Nodes ?
The text was updated successfully, but these errors were encountered:
I'm 👍 on this, as well as equality for Arel::Attributes::Attribute etc. Ran into this on activerecord-hackery/squeel#153 recently. Given how much ActiveRecord relies on the concept of being able to uniq a collection for *_values, we should do what we can to help it along.
Happy to put in the work on this, unless another committer has opposition.
when chaining custom selects in rails like
It produces duplicate select_values. Thats because the select_values array can't be made uniq in
Unlike
Wouldn't it make sense to implement equality for Arel::Nodes ?
Or to be more specific to have a proper implementation of the hash function for Arel::Nodes ?
The text was updated successfully, but these errors were encountered: