Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is mini_racer optional for contributing flow? #47

Closed
junaruga opened this issue Jul 18, 2016 · 2 comments · Fixed by #48
Closed

Why is mini_racer optional for contributing flow? #47

junaruga opened this issue Jul 18, 2016 · 2 comments · Fixed by #48

Comments

@junaruga
Copy link
Contributor

When I tried to set up my development environment,
following
https://github.com/rails/execjs/blob/master/CONTRIBUTING.md
Bundle install and test

I got the error. can not find mini_racer.
Why is mini_racer not installed on default setting?
https://github.com/rails/execjs/blob/master/Gemfile#L8

Maybe contributor wants to succeed all the test "bundle exec rake" without installing mini_racer manually.

$ git clone https://github.com/contributor/execjs.git

$ cd execjs

$ bundle install --path vendor/bundle

$ bundle list
Gems included by the bundle:
  * bundler (1.12.5)
  * duktape (1.3.0.6)
  * execjs (2.7.0)
  * libv8 (3.16.14.15)
  * minitest (5.9.0)
  * rake (11.2.2)
  * ref (2.0.0)
  * therubyracer (0.12.2)

$ bundle exec rake
...
Could not find gem 'mini_racer (= 0.1.0.beta.3)' in any of the gem sources listed in your Gemfile or available on this machine.
Run `bundle install` to install missing gems.
...
PASSED:  test:duktape, test:node, test:rubyracer
SKIPPED: test:javascriptcore, test:jscript, test:rubyrhino, test:v8
FAILED:  test:miniracer
...
@matthewd
Copy link
Member

Because it's mutually exclusive with therubyracer.

Looks like we need to add a EXECJS_RUNTIME=MiniRacer bundle install command to CONTRIBUTING. Want to send a patch?

@junaruga
Copy link
Contributor Author

junaruga commented Jul 18, 2016

@matthewd Okay I got it.

Looks like we need to add a EXECJS_RUNTIME=MiniRacer bundle install command to CONTRIBUTING. Want to send a patch?

It looks good idea.
Yes, I want to send you my patch as a pull-request. Just moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants