Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failed with rails 5.2 #112

Closed
alee-ccu opened this issue Dec 6, 2018 · 1 comment
Closed

Test failed with rails 5.2 #112

alee-ccu opened this issue Dec 6, 2018 · 1 comment

Comments

@alee-ccu
Copy link

alee-ccu commented Dec 6, 2018

Thanks for maintaining globalid.

I am trying to making rails 5.2 available in Debian. During our tests we found this gem fail on tests with rails 5.2:

Failure:
RailtieTest#test_SignedGlobalID.verifier_defaults_to_nil_when_secret_token_is_not_present [/home/travis/build/alee-ccu/globalid/test/cases/railtie_test.rb:41]:
Expected #<GlobalID::Verifier:0x00007f7558521b40 @secret="\xE9\xCD\xAB\xCE\xFF\x93v\x14\xF1\a\xE7/\e\xB2<\xE0\xE3\xA5~\r\xC7\xB5\xEB\xC9`PFx\f\x13\x04vs\x95\xDB\xB1`U\x8FM^(\x7FQ\x7F\xED\xE7U;\xF8r\xB7\x87\xF6\xC8;o\xE7\xBB\xCC\x8E\xFB\xE6\x94", @digest="SHA1", @serializer=Marshal, @options={}, @rotations=[]> to be nil.

I also reproduced the failed tests on travis-ci.org with both version 0.4.1 and master branch, please see the full log at:
https://travis-ci.org/alee-ccu/globalid/jobs/464195985
https://travis-ci.org/alee-ccu/globalid/jobs/464202126

@y-yagi
Copy link
Member

y-yagi commented Dec 6, 2018

Thanks for your report. I fixed with #113. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants