importmap pin --download does not work for multi-files dependencies

[mildred]

I need to have chart.js in my application, if I pin it without the download option, it works fine:

$ bin/importmap pin chart.js
Pinning "chart.js" to https://ga.jspm.io/npm:chart.js@3.9.1/dist/chart.mjs

It will load the following URLs at runtime:

• https://ga.jspm.io/npm:chart.js@3.9.1/dist/chart.mjs
• https://ga.jspm.io/npm:chart.js@3.9.1/_/16cda191.js
• https://ga.jspm.io/npm:chart.js@3.9.1/dist/chunks/helpers.segment.mjs

However, if I run:

$ bin/importmap pin --download chart.js
Pinning "chart.js" to vendor/javascript/chart.js.js via download from https://ga.jspm.io/npm:chart.js@3.9.1/dist/chart.mjs

It does not work because dependent files are not downloaded. I get the following exception in rails:

Asset `chart.js/dist/Chart.js` was not declared to be precompiled in production.
Declare links to your assets in `app/assets/config/manifest.js`.
  //= link chart.js/dist/Chart.js
and restart your server

However, I'd still like to serve the dependency locally

[chuchiperriman]

Same problem here. ¿Some workaround?

[neilvanbeinum]

I came across this problem for another package. Try putting the minified version (e.g. https://ga.jspm.io/npm:chart.js@3.9.1/dist/chart.min.js) into your vendor file instead @chuchiperriman.

Related issue at #65

[mildred]

My workaround is to manually download the files in a vendor directory. Here is my script vendor/download.sh:

#!/bin/bash

cd $(dirname "$0")

main(){
	jspm chart.js 3.9.1

	dl chart.js/dist/chart.mjs
	dl chart.js/_/16cda191.js
	dl chart.js/dist/chunks/helpers.segment.mjs
}

jspm(){
	local pkg="$1"
	local ver="$2"
	local kind=npm
	packages[$pkg]=https://ga.jspm.io/$kind:$pkg@$ver/
}

dl(){
	local path="$1"
	local pkg="${path%%/*}"
	local pkgpath="${path#*/}"
	local dir="${path%/*}"
	local urlprefix="${packages[$pkg]}"
	mkdir -p "javascript/$dir"
	path=${path//.mjs/.js} # because rails-importmap cannot pin .mjs files
	>&2 echo "dl $pkg/${path#*/} $urlprefix$pkgpath"
	curl -s -o "javascript/$path" "$urlprefix$pkgpath"
}

declare -A packages

main "$@"

Then in config/importmap.rb:

pin_all_from 'vendor/javascript'

pin 'chart.js', to: 'chart.js/dist/chart.js'

[dhh]

Would be happy to see a patch where the dependencies are downloaded as well.

[AnalyzePlatypus]

There's a workaround based on JSDelivr here