Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery 1.6.3 & 1.6.4 support #20

Closed
JangoSteve opened this issue Sep 4, 2011 · 5 comments
Closed

jQuery 1.6.3 & 1.6.4 support #20

JangoSteve opened this issue Sep 4, 2011 · 5 comments

Comments

@JangoSteve
Copy link
Member

jQuery 1.6.3 broke some stuff on jquery-ujs. Until it's fixed, I'm hesitant to make it the default for jquery-rails. I opened a ticket in the jquery bug tracker here: http://bugs.jquery.com/ticket/10202

In the meantime, I'll open this ticket to keep track and let people know why jquery-rails is staying at 1.6.2 for the time being.

@JangoSteve
Copy link
Member Author

Just tested, and jquery 1.6.4 still has this issue.

@chrislloyd
Copy link

1.6.4 also fixes a bunch of other bugs. I'd recommend updating jquery-rails and letting users decide which version of the gem they want.

@nurey
Copy link

nurey commented Sep 30, 2011

seconding @chrislloyd

@JangoSteve
Copy link
Member Author

I can't package jquery-rails with a version of jquery that breaks jquery-rails. However, anyone who would like to use jquery 1.6.3/4 is welcome to put the new jquery in their vendor/assets/javascripts directory and require that in their application.js instead of the one that comes vendored with jquery-rails.

I will hopefully be working on a test-case and fix for jquery soon though, so hopefully they can pull it in for the next release.

@JangoSteve
Copy link
Member Author

I finished the test-case and fix for this, and created a pull request in jquery. It sounds like they're not convinced it's a regression, though I disagree. However, at least I understand the problem a bit better and have hacked our test suite to cope for now.

TL;DR jquery-rails v1.0.16 has jquery 1.6.4 and jquery-ui 1.8.16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants