-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jQuery 1.6.3 & 1.6.4 support #20
Comments
Just tested, and jquery 1.6.4 still has this issue. |
1.6.4 also fixes a bunch of other bugs. I'd recommend updating jquery-rails and letting users decide which version of the gem they want. |
seconding @chrislloyd |
I can't package jquery-rails with a version of jquery that breaks jquery-rails. However, anyone who would like to use jquery 1.6.3/4 is welcome to put the new jquery in their vendor/assets/javascripts directory and require that in their application.js instead of the one that comes vendored with jquery-rails. I will hopefully be working on a test-case and fix for jquery soon though, so hopefully they can pull it in for the next release. |
I finished the test-case and fix for this, and created a pull request in jquery. It sounds like they're not convinced it's a regression, though I disagree. However, at least I understand the problem a bit better and have hacked our test suite to cope for now. TL;DR jquery-rails v1.0.16 has jquery 1.6.4 and jquery-ui 1.8.16. |
jQuery 1.6.3 broke some stuff on jquery-ujs. Until it's fixed, I'm hesitant to make it the default for jquery-rails. I opened a ticket in the jquery bug tracker here: http://bugs.jquery.com/ticket/10202
In the meantime, I'll open this ticket to keep track and let people know why jquery-rails is staying at 1.6.2 for the time being.
The text was updated successfully, but these errors were encountered: