Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend jquery-ui-rails gem #51

Merged
merged 1 commit into from Apr 16, 2012
Merged

Recommend jquery-ui-rails gem #51

merged 1 commit into from Apr 16, 2012

Conversation

joliss
Copy link
Contributor

@joliss joliss commented Mar 20, 2012

Related: #46

How do you guys feel about recommending the jquery-ui-rails gem? So far, it seems to be working well for people.

jeremy added a commit that referenced this pull request Apr 16, 2012
Recommend jquery-ui-rails gem
@jeremy jeremy merged commit d12f9e8 into rails:master Apr 16, 2012
@batter
Copy link
Contributor

batter commented Jun 27, 2012

@jeremy @joliss

I am having jquery-rails include jquery-ui into my project without this other jquery-ui-rails gem and was confused as to what was causing it to succeed after re-reading this updated documentation considering I don't have the jquery-ui-rails gem bundled into my project. I feel like the documentation should be modified to say something more along the lines of this:

If you wish to use jQuery UI as well, you can add this line to application.js:

//= require jquery-ui

Alternatively, you may wish to consider (and we recommend) the newer jquery-ui-rails gem, which accepts the same syntax.

After reading the transcript of discussion in the pull request, it appears that you guys are moving to remove the offering of jquery-ui in this gem, but until that is complete, I just think the way the wording is currently doesn't clearly convey that this gem offers the ability to use jquery-ui in your project unless you have the other gem.

@joliss
Copy link
Contributor Author

joliss commented Jun 27, 2012

Sounds good to me. The current wording is unclear indeed.

Do you want to send a pull request?

By the way, you should strike "which accepts the same syntax" -- it actually doesn't.

@batter
Copy link
Contributor

batter commented Jun 27, 2012

Ahh... Well the way it is written now led me to believe it was.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants