Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow filtering workers by hostname, name or even by configuration/queues #29

Open
rosa opened this issue Jan 29, 2024 · 11 comments · May be fixed by #115
Open

Allow filtering workers by hostname, name or even by configuration/queues #29

rosa opened this issue Jan 29, 2024 · 11 comments · May be fixed by #115
Labels
good first issue Good for newcomers

Comments

@rosa
Copy link
Member

rosa commented Jan 29, 2024

Right now we don't have any filters for workers. With a few hundreds of workers, finding the ones you want becomes a bit tricky, and more so if we add #28. It'd be nice to filter them just like we filter jobs.
@rosa rosa added the good first issue Good for newcomers label Jan 29, 2024
@jaredholdcroft
Copy link

I'd like to work on this issue.

@jaredholdcroft jaredholdcroft mentioned this issue Feb 5, 2024
Closed
@Xeitor
Copy link
Contributor

Xeitor commented Mar 19, 2024

hi, is anyone currently working on this? if not, I would like to give it a try :)

@jaredholdcroft
Copy link

Still me! I was waiting for #28 and then got busy. Hoping to have a PR done this weekend.

@Xeitor
Copy link
Contributor

Xeitor commented Mar 19, 2024

sure no problem

@matiassalles99
Copy link
Contributor

hey! anyone currently working on this issue? Looks like a good one to get started on this project and I would love to give it a try

@jaredholdcroft jaredholdcroft removed their assignment Apr 3, 2024
@jaredholdcroft
Copy link

I've unassigned myself, life got in the way of this unfortunately.

@matiassalles99
Copy link
Contributor

matiassalles99 commented Apr 3, 2024 •
edited

🙁 sorry to hear that. I can take a look at it throughout this week, I should have something ready to review by Sat/Sun

@Xeitor Xeitor linked a pull request Apr 10, 2024 that will close this issue
Draft
3 tasks
@Xeitor
Copy link
Contributor

Xeitor commented Apr 10, 2024

hi @matiassalles99, I took de liberty to open a PR draft since I did some work with jobs filters and this was pretty similar

@matiassalles99
Copy link
Contributor

matiassalles99 commented Apr 10, 2024 •
edited

@Xeitor sg, I added name and hostname filters a couple of days ago but didn't open a PR - feel free to grab any changes from my branch if they come in handy (https://github.com/rails/mission_control-jobs/compare/main...matiassalles99:mission_control-jobs:worker-filters?expand=1)

@Xeitor
Copy link
Contributor

Xeitor commented Apr 10, 2024 •
edited

ohh sorry @matiassalles99, you can go ahead and submit yours

@matiassalles99
Copy link
Contributor

@Xeitor nah it's fine don't worry, I can take a look at another issue 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Workers filters Xeitor/mission_control-jobs
4 participants
@jaredholdcroft @rosa @Xeitor @matiassalles99