Skip to content
This repository has been archived by the owner on May 5, 2019. It is now read-only.

Automatic close pull requests to reflection files #3

Open
rafaelfranca opened this issue Sep 23, 2015 · 4 comments
Open

Automatic close pull requests to reflection files #3

rafaelfranca opened this issue Sep 23, 2015 · 4 comments

Comments

@rafaelfranca
Copy link
Member

Even with the comment on top of the file people still send PRs changing inflectors. We can detect it and warn or even automatically close all PRs that touches this file.

Thoughts @sgrif @fxn @matthewd

@sgrif
Copy link

sgrif commented Sep 23, 2015

Seems reasonable. We can probably have the automated message give 100% of the context needed.

@fxn
Copy link
Member

fxn commented Sep 23, 2015

👍

@matthewd
Copy link
Member

Does this come up enough to bother? My recollection is that most of the inflection reports we see are issues, not PRs.

@rafaelfranca
Copy link
Member Author

I see at least one per month. I thought that given we have a way to automatize the feedback we could use it, but we can keep doing it manually too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants