Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecations for invalid precompile options #636

Open
schneems opened this issue Oct 10, 2019 · 2 comments
Open

Add deprecations for invalid precompile options #636

schneems opened this issue Oct 10, 2019 · 2 comments

Comments

@schneems
Copy link
Member

As described in #632

When people are using a Proc it will work with sprockets 3 and fail with sprockets 4 (I think, still no repro example). We need to:

  1. Validate that is the case
  2. If so, then add deprecations to Sprockets 3.x
@rafaelfranca
Copy link
Member

For sprockets 4 people should use the manifest file. We already raise an error when you boot the app and has no manifest file. We probably just need to expand the error message explaining what needs to be done. The precompile option is not the main way to tell sprockets which files to compile anymore. And yes, it doesn't support procs.

@schneems
Copy link
Member Author

From #632 it sounds like the issue is that gems want to hook into the asset pipeline and not developers adding it manually https://twitter.com/rossta/status/1182352920903344128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants