Thor should return nonzero exit status when a task is not found

[fj]

Consider a simple Thor class:

class Foo < Thor
  no_tasks do
    def initialize(*)
      super
    end

    def exit_on_failure?; true; end
  end

  def arbitrary; shell.say "invoked"; end
end

When I run a binary foo_runner that uses this class and a task is not found, I get a zero status code. This is not the expected behavior; I want to see a nonzero status code if a task is not found.

$ foo_runner arbitrary; echo $?
invoked
0

$ foo_runner missing_command; echo $?
Could not find task "missing_command".
0  # <-- Expected nonzero return value here.

[tpitale]

+1

[eventualbuddha]

Could you also post the source of the foo_runner binary so we'll have a full test case?

[fj]

foo_runner is just Foo.start.

[eventualbuddha]

So it looks like this?

#!/usr/bin/env ruby
Foo.start

[fj]

Here's a simple class you can use for a test case:

#!/usr/bin/env ruby
require 'thor'

class Foo < Thor
  no_tasks do
    def initialize(*)
      super
    end

    def exit_on_failure?; true; end
  end

  desc "arbitrary", "a simple task"
  def arbitrary; shell.say "invoked"; end
end

Foo.start

At the command line:

$ chmod +x foo_runner.rb

$ ./foo_runner.rb arbitrary; echo $?
invoked
0    # <-- Expected 0, got 0. Pass.

$ ./foo_runner.rb kablammo; echo $?
Could not find task "kablammo".
0    # <-- Expected non-zero, got 0. Fail.

[josevalim]

Patch please!

[ldenman]

Two years later and I am wondering if a fix for this was ever implemented?

Thanks.

[akahn]

This was supposedly fixed for #1 in 0229237. @josevalim, is the purpose of exit_on_failure? to allow different classes to configure whether or not they exit on failure? Would it be acceptable to change the default to true?