Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thor 1.3.0 No Longer calling a system exit #870

Open
xtreme-shane-lattanzio opened this issue Jan 19, 2024 · 1 comment
Open

Thor 1.3.0 No Longer calling a system exit #870

xtreme-shane-lattanzio opened this issue Jan 19, 2024 · 1 comment
Labels
needs-info Not enough detail to understand the issue

Comments

@xtreme-shane-lattanzio
Copy link

We have a test that explicitly calls an exit 0 under certain conditions which should then trigger SystemExit. I am not sure what change caused this but when upgrading to Thor 1.3.0 from 1.2.2, SystemExit is no longer called in this case. I know that there were changes in 1.0.0 around exit_on_failure? (which I am not explicitly calling at this point) but looking through the code changes for the 1.3.0 update, I cannot see what possibly could be the issue. Would someone be able to point me in the right direction? Not sure if I need to change something or if the behaviour I had is simply no longer possible. Thanks!!

@rafaelfranca
Copy link
Member

Hard to know how to point you to the right direction if we don't know how to reproduce the problem. Could you please provide information on how we can reproduce the problem?

@rafaelfranca rafaelfranca added the needs-info Not enough detail to understand the issue label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-info Not enough detail to understand the issue
Projects
None yet
Development

No branches or pull requests

2 participants