This repository has been archived by the owner on Jul 28, 2018. It is now read-only.
Preserve anchors - Fix #110 #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
It's just personal preference. I like the way I did it, but I'd have no issue with changing it. I'll leave it up to @dhh to decide how he wants it before adding another commit. |
|
I see. Also since Turbolinks is completly bracketless it's pointless to try add brackets to improve readability. I'm just point you to opportunity remove two more brackets 😸. |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came up with a few ways to fix the problem (#110), but I think this one is the best because it takes care of two issues.
Unless I'm missing something, the purpose of the
reflectRedirectedUrlfunction is to update the newly pushed (fromreflectNewUrl) history state in the event the ajax request is redirected. However, right now it's doing it whether there was a redirect or not, which most of the time will be unnecessary. The lost anchors are a side effect of this, since it replaces the current state with theX-XHR-Current-Locationvalue from the server (which omits anchors). As far as I can tell, my solution preserves the anchors while eliminating unnecessary replaceState calls.