Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a standard lint setup for contributors #128

Closed
justin808 opened this issue Feb 27, 2017 · 2 comments
Closed

Need a standard lint setup for contributors #128

justin808 opened this issue Feb 27, 2017 · 2 comments

Comments

@justin808
Copy link
Contributor

Is there an eslint configuration that should pass for the generated files?

I'd recommend this one solely because it's so widely used and well supported:

https://github.com/airbnb/javascript/tree/master/packages/eslint-config-airbnb

While a particular one is not so critical, I'd err on the side of being stricter than looser.

The files included by the generator should pass some lint configuration, and supposing they change in the future, the linter should be run as part of CI.

For example, this would be file to check. https://github.com/rails/webpacker/blob/master/lib/install/config/development.js

This project could have a package.json with standard tasks such as 'lint' and that can be run by CI.

If deemed useful, I could create a PR.

@ytbryan
Copy link
Contributor

ytbryan commented Feb 27, 2017

I believe there's one here #111

@justin808
Copy link
Contributor Author

Thanks @ytbryan! That's what's needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants