Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"packs" or "bundles" #136

Closed
justin808 opened this issue Feb 28, 2017 · 2 comments
Closed

"packs" or "bundles" #136

justin808 opened this issue Feb 28, 2017 · 2 comments

Comments

@justin808
Copy link
Contributor

It seems that the term "pack" is synonymous with the webpack documentation for bundles.

Eventually, we'll want to configure larger Rails apps to support Code Splitting.

The advantage of using the term "bundles" in the directories and docs is that it will be immediately obvious to the experienced webpack users what these are.

However, maybe we want to use the terms "pack" and "packs" to specifically mean webpack bundles configured via the Rails default configuration of entry points. So maybe "packs" is better?
(but per discussion below, we cannot restrict finding the "pack" files).

Another issue we need to consider is splitting the vendor bundle.

Luckily, Webpack now supports an implicit vendor bundle.

This means that we'll have a "pack" (or bundle) that does not map to a file in the /app/javascripts/packs directory. So long as we're depending on the manifest file that @gauravtiwari is using, and not so much on what's in the "packs" directory, then we should be covered.

Plus, there's another import piece to the puzzle of using a "vendor bundle", which is the manifest file.

@lookitsatravis
Copy link

One thing to consider is using "bundle" for webpack could get quite confusing when referring to "bundle" for the bundler gem.

@dhh
Copy link
Member

dhh commented Mar 1, 2017

Yeah, I went over this from a lot of different angles when deciding on "packs". We have a lot of overloading of the word "bundle" in the Rails world, so packs provided a uncontested word we can use. We are balancing multiple domains and ecosystems here, so there's some give and take. Optimizing solely for what an experienced webpack user would expect isn't going to give that.

@dhh dhh closed this as completed Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants