Make clean task simpler and fix issues #2389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If someone could review this and will merge later today and make a new release. |
Tidy up Compact Update message Remove message Inline
gauravtiwari
force-pushed
the
fix-clean-task
branch
from
03fb4c2
to
8fb2632
Compare
|
Since the previous version broke the assets:clean workflow. Releasing this early as possible will be great |
|
Already released @tachyons 4.2.1 |
|
We were seeing the cleanup_assets error on random basis with 4.2.0, with 4.2.1 we have it on each deploy. |
|
Yes, 4.2.1 broken for us too |
|
Made a quick fix here #2391 |
glebm
added a commit
to thredded/thredded
that referenced
this pull request
Dec 30, 2019
Following rails/webpacker#2389 Requires webpacker v4.2+
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes clean task simpler, without reliance on regex, which are hard to reason and also a bit brittle. Also, noticed the previous implementation didn't remove some files.
The clean task will always preserve, the latest version and a backup version in the packs folder.
Closes #2384
Closes #2382
Closes #2385
Fixes #2372