Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpacker 6.x - Compatibility with Webpack 5 #2757

Closed
pedrofurtado opened this issue Oct 10, 2020 · 18 comments
Closed

Webpacker 6.x - Compatibility with Webpack 5 #2757

pedrofurtado opened this issue Oct 10, 2020 · 18 comments

Comments

@pedrofurtado
Copy link
Member

pedrofurtado commented Oct 10, 2020

A great news, everyone! 馃帀

Webpack v5 is ready: https://github.com/webpack/webpack/releases/tag/v5.0.0

Happy to see upgrade plans to this version 馃

I can help with testing (not too much with code, in this particular case 馃槃)

@addamove
Copy link

Waiting...

@Ruff9
Copy link

Ruff9 commented Oct 13, 2020

It would help fix a lot of security issues introduced by webpack 4.44.2.
(for example : #2216)

@gauravtiwari
Copy link
Member

Thanks @pedrofurtado

I am working towards a 6.0 release that will include Webpack 5 support but we are still a couple of weeks away.

@guillaumebriday
Copy link
Member

@gauravtiwari If you need help, feel free to ping me 馃憤

I tried to upgrade a webpack-boilerplate to Webpack 5, and most of plugins and loaders are not compatible yet :/

I guess we must wait a bit.

@brentdodell
Copy link

@gauravtiwari, do you have a date that you'd like to have Webpack 5 support out? Are there a list of action items that need to happen to get it there?

@gauravtiwari
Copy link
Member

Thanks, @guillaumebriday will definitely do

@brentdodell

The main goal with 6.0 is to make Webpacker leaner:

optional features are basically like you would add haml-rails gem to use haml templating engine

which means we will move away from rake installers - erb, react etc. In my opinionm, installers don't do much anyway and anyone can simply follow the docs to add bunch of dependencies to get started (much better for learning).

We will document all installer steps in the docs. And, you can also use NPM, if needed.


I can't promise the exact date but Rails 6.1 RC is due soon (end of October/first week november) so hopefully around that time.

@gauravtiwari
Copy link
Member

@pedrofurtado wondering if we can remove the title of the issue to reflect Webpacker 6.0 instead of Webpack 5?

@pustovalov
Copy link
Contributor

one of the blockers:

webpack-assets-manifest - currently doesn't support webpack 5, webdeveric/webpack-assets-manifest#59 (comment)

@gauravtiwari gauravtiwari changed the title Webpack v5 is out! Webpacker 6.0 Oct 27, 2020
This was referenced Nov 25, 2020
@guillaumebriday
Copy link
Member

I opened a PR to remove the installers here: #2797

Please let me know if I need to change something

@anark
Copy link
Contributor

anark commented Dec 1, 2020

Any news on this? It looks like webpack-asset-manifest is close to a webpack 5 compatible release.

I also think removing the css stuff(and postcss), file loaders, and the installers and making webpacker default to js only and other options be opt in would be a great change

@gauravtiwari
Copy link
Member

thanks @anark I will check if it's good to go but I didn't see any new release for webpack 5?

@guillaumebriday thanks for the PR and help, I really appreciate it. Sorry, I didn't publish my work, which has similar changes to yours but others like documentation and optional support for those installers.

I will review the state of my work and try to publish a PR later this week.

@guillaumebriday
Copy link
Member

Ok great! I didn't write documentation because I wasn't sure how guys you wanted to see in it. That's why my PR is in draft state 馃憤

By optional support for those installers, you want something like Laravel Frontend Preset? Extract installers in dedicated gems?

@n-rodriguez
Copy link
Contributor

@pustovalov webpack-asset-manifest has been updated : https://github.com/webdeveric/webpack-assets-manifest/releases/tag/v4.0.0

@webdeveric
Copy link

I published webpack-assets-manifest v5 and it supports webpack 5. There were lots of updates in v4 and v5 and a couple breaking changes so please read the release notes.

@pedrofurtado pedrofurtado changed the title Webpacker 6.0 Compatibliity with Webpack 5 Dec 21, 2020
@pedrofurtado pedrofurtado changed the title Compatibliity with Webpack 5 Compatibility with Webpack 5 Dec 21, 2020
@pedrofurtado pedrofurtado changed the title Compatibility with Webpack 5 Webpacker 6.x - Compatibility with Webpack 5 Dec 21, 2020
@pedrofurtado
Copy link
Member Author

pedrofurtado commented Jan 21, 2021

Hey, guys! I will close this issue because webpack 5 is now supported in master branch, and it is available in latest 6.x release (at this moment is v6.0.0.beta.3) 馃帀

Thanks the help of all 馃

@gsouf
Copy link

gsouf commented Mar 12, 2021

Hi @pedrofurtado is the v6-beta stable enough atm?

Thanks

@pedrofurtado
Copy link
Member Author

Hi @gsouf ! 馃嵒 The 5.x is stable, the 6.x may contain some more additional breaking changes 馃憤

@olivierlacan
Copy link

Hi @gsouf ! 馃嵒 The 5.x is stable, the 6.x may contain some more additional breaking changes 馃憤

@pedrofurtado Would that be breaking changes upgrading from Webpacker 5.x to 6.x or actual breaking issues in Webpacker 6.x/master? Curious and willing to help squash any outstanding issues by the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests