Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: --colors is not a valid options in webpack 5 #3138

Closed
tagliala opened this issue Aug 25, 2021 · 2 comments · Fixed by #3144
Closed

Docs: --colors is not a valid options in webpack 5 #3138

tagliala opened this issue Aug 25, 2021 · 2 comments · Fixed by #3144

Comments

@tagliala
Copy link
Contributor

tagliala commented Aug 25, 2021

https://github.com/rails/webpacker/blame/master/README.md#L214

$ ./bin/webpack --watch --colors --progress
[webpack-cli] Error: Unknown option '--colors'
[webpack-cli] Run 'webpack --help' to see available commands and options

Also, colors seems enabled by default

It may be also worth to note that ./bin/webpack --help does not work anymore

Webpacker v6

$ ./bin/webpack --help
[webpack-cli] Incorrect use of help
[webpack-cli] Please use: 'webpack help [command] [option]' | 'webpack [command] --help'
[webpack-cli] Run 'webpack --help' to see available commands and options

Webpacker v5

$ bin/webpack --help
webpack-cli 3.3.12

Usage: webpack-cli [options]
...
@guillaumebriday
Copy link
Member

Nice catch, will dig into that later this week

@guillaumebriday
Copy link
Member

Ok I did some tests. Colors are enabled by default in Webpack 5, but we can disable them with --no-color and remove --color (note that is singular now) from your command.

The help command changed a lot between Webpack 4 and 5. I opened a PR to allow usage of these commands: #3144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants