Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect RAILS_ENV and NODE_ENV in webpack-dev-server binstub #502

Merged
merged 1 commit into from Jun 15, 2017

Conversation

rossta
Copy link
Member

@rossta rossta commented Jun 14, 2017

The following changes substitute hard-coded 'development' usages with respective RAILS_ENV and NODE_ENV values. This would be one step in paving the way for running a separate webpack-dev-server in test env as opposed to lazy-compiling assets to packs-test.

@gauravtiwari gauravtiwari merged commit 59aabc6 into rails:master Jun 15, 2017
@gauravtiwari
Copy link
Member

Thanks @rossta 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants